TST: test wuhan on nightly and push to main #152
Conversation
|
@jGaboardi pls review the current state but do not merge yet. I'll play with it a bit once I merge main to figure out Wuhan. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
=======================================
- Coverage 98.8% 98.8% -0.0%
=======================================
Files 6 6
Lines 1001 1000 -1
=======================================
- Hits 989 988 -1
Misses 12 12 |
|
|
||
|
|
||
| @pytest.mark.wuhan | ||
| def test_simplify_network_wuhan(aoi="wuhan_8989", tol=0.3, known_length=4_702_861): |
There was a problem hiding this comment.
My thought here would be to have a single helper that runs the guts of this function + test_simplify_network_full_fua() and is called within each. That could also be adapted for test_simplify_network_small(). But that can wait until another PR for sure (if we decide to do).
|
@martinfleis This PR is still in limbo, correct? I merely want to make sure that I am not holding anything up. |
|
Yeah, it is waiting for me and might be for a while. |
Closes #149
this sits on top of #151 to generate the simplified network. Should run only on merge to main, nightly and workflow trigger, never on a PR as it will likely take a bit (7m33s on M1 locally).