Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call_with_config string #1743

Closed
wants to merge 1 commit into from

Conversation

dhilst
Copy link

@dhilst dhilst commented Sep 3, 2024

Summary

Closes #_

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on the specific version of ink or pallet-contracts?

Description

Hi everybody! Following the ink tutorial, I found a problem
with the cargo contract upload command. It returns the below error: at https://use.ink/getting-started/calling-your-contract

image

After the patch:
image

The patch is so small that I didn't bother to add a test just for it,

Checklist before requesting a review

  • [y] My code follows the style guidelines of this project
  • [y] I have added an entry to CHANGELOG.md
  • [n/a] I have commented on my code, particularly in hard-to-understand areas
  • [n] I have added tests that prove my fix is effective or that my feature works
  • [n] Any dependent changes have been merged and published in downstream modules

@cmichi
Copy link
Collaborator

cmichi commented Nov 4, 2024

Thanks for the PR, @dhilst! I'm closing in favor of #1786, which supports both behaviors of stringify!, spaced and non-spaced.

@cmichi cmichi closed this Nov 4, 2024
@Lohann
Copy link

Lohann commented Nov 15, 2024

Can we reopen it? this issue now happens if you build this repo with and olde rust version, in my case 1.79.0-aarch64-apple-darwin

@cmichi
Copy link
Collaborator

cmichi commented Nov 20, 2024

@Lohann The fix has been merged into this repo and was just released with cargo-contract v4.1.3. You can update via cargo install --locked cargo-contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants