Fix "chain configuration not found" error #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
added a commit
that referenced
this pull request
Nov 5, 2024
* Account for spaced and non-spaced behavior of `stringify!` * For user output: remove spaces from object path * Output the chain configuration that was searched * Apply `cargo fmt` * Add changelog entry * Switch spaces clean-up * Fix string handling * Apply `cargo fmt` * Improve comment * Improve formatting * Improve assert error message * Shorten code
Merged
cmichi
added a commit
that referenced
this pull request
Nov 6, 2024
* Fix "chain configuration not found" error (#1786) * Account for spaced and non-spaced behavior of `stringify!` * For user output: remove spaces from object path * Output the chain configuration that was searched * Apply `cargo fmt` * Add changelog entry * Switch spaces clean-up * Fix string handling * Apply `cargo fmt` * Improve comment * Improve formatting * Improve assert error message * Shorten code * Update changelog * Bump version number * Update `Cargo.lock`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #1743.
inkorpallet-contracts?Description
If
cargo-contractis installed with newer Rust versions this error will appear when using commands that interact with a chain (instantiate,upload,call, etc.).User @dhilst reported this and took this screenshot:
The root of the error is that
stringify!on paths likecrate::foocan yield eithercrate :: foo(with spaces, in newer Rust versions) orcrate::foo(without spaces, in older Rust versions). See rust-lang/rust#128992 for more details.The merge of this behavior into Rust
masteroccurred in rust-lang/rust#125174 on June 12. Nightlies after that are affected and from what I can tell stable from 1.81 on (though I haven't explicitly bisected the version).This PR makes
cargo-contractwork with either behavior.As a follow-up I'll do a backported
4.xpatch release.