doc: Solidity class fields to Rust struct #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xf333
requested review from
cmichi,
ascjones,
SkymanOne and
DoubleOTheven
as code owners
SkymanOne
reviewed
Aug 28, 2023
0xf333
force-pushed
the
0xf333/Solidity_class_to_Rust_struct
branch
from
5f2f931
to
4471b72
Compare
Fix solidity example and update ink example to conform with v4 Description ============ - Added SPDX license identifier for Solidity. - Fixed the syntax for the `if` condition in Solidity. - Fixed event emit syntax. - Added `no_main` attribute in ink! contract.
0xf333
force-pushed
the
0xf333/Solidity_class_to_Rust_struct
branch
from
4471b72
to
b802fa9
Compare
|
This should probably be fixed in a separated pull request since it's not part of this PR scope. Let me know what you think. |
Reason for separated PR is to ensure that each link issue was resolved independently, providing a clearer history. |
ascjones
reviewed
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix solidity example and update ink example to conform with v4
Description
ifcondition in Solidity.no_mainattribute in ink! contract.