fix: update link to upgradeable-contracts #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outdated links are causing `markdown-link-check` check to fail during pull request checks. Description =========== - Old link: ../paritytech/ink-examples/tree/main/upgradeable-contracts - Replaced by: ../paritytech/ink/tree/master/integration-tests/upgradeable-contracts Impact ====== This PR fixes failure associated with upgradeable-contracts link.
0xf333
requested review from
cmichi,
ascjones,
SkymanOne and
DoubleOTheven
as code owners
This was referenced Sep 4, 2023
ascjones
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Actually the upgradeable-contracts were removed in use-ink/ink-examples#39, because they were no longer part of ink/integration-tests. However they are now back since use-ink/ink#1889, so instead of changing the links we should restore the upgreadeable-contracts to ink-examples
In that case this PR should be closed then, since the upgradable contract link will remain the same |
|
Closing this PR since the upgradable contract link will remain the same. |
0xf333
added a commit
to 0xf333/ink-examples
that referenced
this pull request
Sep 8, 2023
Description
===========
This PR serves two purposes:
- Adjusts ink-examples to align with integration
test repositories.
- Fixes the previous URL check failure from Ink-docs.
For more context, please refer to Ink-docs PR 273.
Impact
======
This PR addresses markdown-link-check issue in Ink-docs:
use-ink/ink-docs#273
0xf333
added a commit
to 0xf333/ink-examples
that referenced
this pull request
Sep 11, 2023
Description
===========
This PR serves two purposes:
- Adjusts ink-examples to align with integration
test repositories.
- Fixes the previous URL check failure from Ink-docs.
For more context, please refer to Ink-docs PR 273.
Impact
======
This PR addresses markdown-link-check issue in Ink-docs:
use-ink/ink-docs#273
0xf333
added a commit
to 0xf333/ink-examples
that referenced
this pull request
Sep 11, 2023
Description
===========
This PR serves two purposes:
- Adjusts ink-examples to align with integration
test repositories.
- Fixes the previous URL check failure from Ink-docs.
For more context, please refer to Ink-docs PR 273.
Impact
======
This PR addresses markdown-link-check issue in Ink-docs:
use-ink/ink-docs#273
* fix: update set-code-hash path in ci
0xf333
added a commit
to 0xf333/ink-examples
that referenced
this pull request
Sep 11, 2023
Description
===========
This PR serves two purposes:
- Adjusts ink-examples to align with integration
test repositories.
- Fixes the previous URL check failure from Ink-docs.
For more context, please refer to Ink-docs PR 273.
Impact
======
This PR addresses markdown-link-check issue in Ink-docs:
use-ink/ink-docs#273
* fix: update set-code-hash path in ci
* fix: adjust ci for upgradable-contracts directory
Description
===========
- Added environment variable UPGRADEABLE_CONTRACTS.
- Adjusted ci to process contracts under the
upgradeable-contracts directory.
- Removed unnecessary foo, bar feature flags from the
CI steps as they were not present in Cargo.toml files
0xf333
added a commit
to 0xf333/ink-examples
that referenced
this pull request
Sep 11, 2023
Description
===========
This PR serves two purposes:
- Adjusts ink-examples to align with integration
test repositories.
- Fixes the previous URL check failure from Ink-docs.
For more context, please refer to Ink-docs PR 273.
Impact
======
This PR addresses markdown-link-check issue in Ink-docs:
use-ink/ink-docs#273
* fix: update set-code-hash path in ci
* fix: adjust ci for upgradable-contracts directory
Description
===========
- Added environment variable UPGRADEABLE_CONTRACTS.
- Adjusted ci to process contracts under the
upgradeable-contracts directory.
- Removed unnecessary foo, bar feature flags from the
CI steps as they were not present in Cargo.toml files
0xf333
added a commit
to 0xf333/ink-examples
that referenced
this pull request
Sep 11, 2023
Description
===========
This PR serves two purposes:
- Adjusts ink-examples to align with integration
test repositories.
- Fixes the previous URL check failure from Ink-docs.
For more context, please refer to Ink-docs PR 273.
Impact
======
This PR addresses markdown-link-check issue in Ink-docs:
use-ink/ink-docs#273
* fix: update set-code-hash path in ci
* fix: adjust ci for upgradable-contracts directory
Description
===========
- Added environment variable UPGRADEABLE_CONTRACTS.
- Adjusted ci to process contracts under the
upgradeable-contracts directory.
- Removed unnecessary foo, bar feature flags from the
CI steps as they were not present in Cargo.toml files
ascjones
pushed a commit
to use-ink/ink-examples
that referenced
this pull request
Sep 12, 2023
Description
===========
This PR serves two purposes:
- Adjusts ink-examples to align with integration
test repositories.
- Fixes the previous URL check failure from Ink-docs.
For more context, please refer to Ink-docs PR 273.
Impact
======
This PR addresses markdown-link-check issue in Ink-docs:
use-ink/ink-docs#273
* fix: update set-code-hash path in ci
* fix: adjust ci for upgradable-contracts directory
Description
===========
- Added environment variable UPGRADEABLE_CONTRACTS.
- Adjusted ci to process contracts under the
upgradeable-contracts directory.
- Removed unnecessary foo, bar feature flags from the
CI steps as they were not present in Cargo.toml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outdated links are causing
markdown-link-checkcheck to fail during pull request checks.
Description
Old link: ../paritytech/ink-examples/tree/main/upgradeable-contractsReplaced by: ../paritytech/ink/tree/master/integration-tests/upgradeable-contractsImpact
This PR fixes failure associated with upgradeable-contracts link.