feat: introduce warning system #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
build-warnings
branch
2 times, most recently
from
d424e15 to
c7e6a67
Compare
shreddedbacon
force-pushed
the
build-warnings
branch
9 times, most recently
from
28692bc to
1a7968d
Compare
shreddedbacon
force-pushed
the
build-warnings
branch
from
1a7968d to
20d6d9f
Compare
tobybellwood
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just introduces some basic warning capturing functionality.
It doesn't capture warnings from anything that a user may do during a build, but anything that we decide to capture will easily be able to utilise the functionality.
It would be cool to be able to capture things from a docker image build process, or from a pre/post rollout task, but this would require parsing the logs from these processes, which we currently do not do (but could maybe do in the future?)
This does not require the UI changes to be merged, the UI changes just make the warnings actually show up, otherwise the warning features are ignored.