feat: support warnings #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
warnings-poc
branch
8 times, most recently
from
7e5b718 to
a59c9c8
Compare
|
Just a PoC for how uselagoon/build-deploy-tool#255 could be displayed
It uses an existing warning icon image found in the repository, but would probably benefit from some ✨ |
shreddedbacon
force-pushed
the
warnings-poc
branch
3 times, most recently
from
08495c4 to
3f9ad75
Compare
shreddedbacon
force-pushed
the
warnings-poc
branch
from
3f9ad75 to
4ee4810
Compare
|
@shreddedbacon I made some small changes to the hoverTag component - optionally applying props; human friendly formatting for a warning; And a condition how the warning hovertags are rendered. A bit of stylistic/ icon changes to |
|
Sweet, had a look, looks good. |
shreddedbacon
requested review from
DaveDarsa,
tobybellwood and
CGoodwin90
and removed request for
DaveDarsa
DaveDarsa
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for warnings in the UI. This will only ever be exposed when the build provides the necessary information to change the accordions