Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support drush gt 8 #2906

Merged
merged 6 commits into from
Nov 4, 2021

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Nov 3, 2021

As described in #1787, the Lagoon UI sync tasks fail for newer versions of Drush because of the alias handling.

This builds on @mglaman's solution and includes the file sync task, which suffers from the same issue.

I've changed the logic slightly to only prefix the site alias when the lagoon:alias command is explicitly supported by Drush, since this is as good an indication as I can think of that the Drupal Integration modules is available.

This is only a short term fix - we will be deprecating these tasks and their corresponding API calls in the medium term.

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Explain the details for making this change. What existing problem does the pull request solve?

Closing issues

Closes #1786

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok:
for projects with drupal_integrations, it works as expected (#2911 excepted)
for projects without drupal_integrations it relies on coded aliases

@tobybellwood tobybellwood merged commit 60c93fb into uselagoon:main Nov 4, 2021
@bomoko bomoko deleted the feature/support_drush_gt_8 branch December 7, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql-sync fails with Drush 9
2 participants