Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build step patching, and time and duration messaging #2922

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Closing issues

closes #1082
partially closes #2908

@tobybellwood
Copy link
Member

smol change to the message printing - now in a one liner with the timezone too

STEP Post-Rollout Tasks: Completed at 2021-11-09 23:39:44 (UTC) Duration 00:00:01 Elapsed 00:00:23

also added a teensy 0.5s sleep after apply to allow the logs to pause whilst pushed to try to pin message to the bottom.

@shreddedbacon
Copy link
Member Author

Sweet. I think for now the tiny message grab at the bottom is unavoidable though. Even with a forced sleep it might still capture them if the controller is a bit slow on a busy cluster.

With more staged build script, or staged build pods, we could probably handle this better in lagoon-kbd in the future though.

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great step towards incremental logs!

@tobybellwood tobybellwood merged commit f0337ef into main Nov 10, 2021
@tobybellwood tobybellwood deleted the buildstep-times branch November 10, 2021 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental Builds Logs Timings in build logs
2 participants