Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for task "complete" status, as succeeded is being deprecated #3168

Merged
merged 2 commits into from
Jun 3, 2022
Merged

fix: check for task "complete" status, as succeeded is being deprecated #3168

merged 2 commits into from
Jun 3, 2022

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jun 3, 2022 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

#3114 added additional enums for tasks to be more like deployments, the tests should leverage the newer enums as well as the older ones for now until remote-controller has been released long enough with the update

@tobybellwood tobybellwood merged commit ce0c724 into main Jun 3, 2022
@tobybellwood tobybellwood deleted the activestandby-test-check branch June 3, 2022 08:04
@tobybellwood tobybellwood changed the title test: check for task complete, as succeeded is being deprecated fix: check for task "complete" status, as succeeded is being deprecated Jun 3, 2022
tobybellwood added a commit that referenced this pull request Jun 8, 2022
@tobybellwood
backport of #3168
69d9d0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood