Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for task "complete" status, as succeeded is being deprecated #3168

Merged
merged 2 commits into from
Jun 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions services/controllerhandler/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ const messageConsumer = async function(msg) {
// that we get back from the controllers
case "kubernetes:route:migrate":
switch (meta.jobStatus) {
case "complete":
case "succeeded":
try {
// since the advanceddata contains a base64 encoded value, we have to decode it first
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/active-standby/deploy-active-standby.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
body_format: json
body: '{ "query": "query($id: Int!) {taskById(id: $id){status}}", "variables": {"id":{{ apiresponse.json.data.switchActiveStandby.id }}}}'
register: taskresult
until: taskresult.json.data is defined and (taskresult.json.data.taskById.status == "succeeded" or taskresult.json.data.taskById.status == "failed")
until: taskresult.json.data is defined and (taskresult.json.data.taskById.status == "complete" or taskresult.json.data.taskById.status == "succeeded" or taskresult.json.data.taskById.status == "failed")
retries: 20
delay: 10
- name: "{{ testname }} - fail if task fails"
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/tasks/create-register-and-test-image-task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@
body_format: json
body: '{ "query": "query($taskId: Int!) {taskById(id:$taskId){status}}", "variables": {"taskId": {{ invokeRegisteredTaskApiResponse.json.data.invokeRegisteredTask.id }}}}'
register: result
until: result.json.data.taskById.status == "succeeded"
until: (result.json.data.taskById.status == "complete" or result.json.data.taskById.status == "succeeded")
retries: 90
delay: 20