chore: remove remaining harbor integration from core #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@shreddedbacon to flag this for deprecation in the next release - and then this PR will remove it in a future release. |
4 tasks
4 tasks
shreddedbacon
force-pushed
the
remove-harbor-project-integration
branch
from
89418ac to
af3fbc3
Compare
shreddedbacon
changed the title
shreddedbacon
force-pushed
the
remove-harbor-project-integration
branch
from
9ba78bf to
c58dcf7
Compare
shreddedbacon
added
the
happy-to-delay
shreddedbacon
force-pushed
the
remove-harbor-project-integration
branch
from
c58dcf7 to
9d48aff
Compare
shreddedbacon
force-pushed
the
remove-harbor-project-integration
branch
from
9d48aff to
02dffe2
Compare
tobybellwood
approved these changes
Jun 27, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
As #2907 outlines, we need to remove harbor support from core as this integration is no longer required.
There is already some work in #3086 to remove other harbor integrations
This is an actual breaking change, but as outlined in Lagoon v2.18.0, harbor support in core would be removed in a future release.
This pullrequest also completely removes the harbor integration and all API queries and mutations that were changed to return errors in 2.18.0 as part of #3672. Anyone that was still using any of these would have been getting errors since v2.18.0.
Closing issues
partially #2907