chore: remove unneeded reference to legacy registry setting #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
remove-legacy-registry
branch
from
13725e3 to
9cc4675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
Just removes an unneeded reference to a registry. This variable is not consumed by anything in core beyond passing it through to the remote. The usage of this is from a historical perspective, it was used when Lagoon didn't have support for harbor in core, or harbor in remote.
It isn't related to the legacy harbor implementation in core either as these provide variables to the project in the form of
INTERNAL_REGISTRY_Xwhich get added to the build payload when it sent to a remote. The legacy harbor implementation in core is planning to be removed (#2907 , #3259, and others) and was announced as deprecated in v2.17.0Closing issues
closes #2238