Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle more duplicate insert errors #3424

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

One idea for handling duplicate inserts. There are probably other places this needs to be done.

It could probably be done better with transactions or try/catch?

Happy if anyone else wants to take this on though, just planting this as a seed

@CGoodwin90 CGoodwin90 marked this pull request as ready for review December 1, 2023 02:22
@tobybellwood
Copy link
Member

@CGoodwin90 to resuscitate, rebase and update

@tobybellwood tobybellwood added this to the 2.20.0 milestone May 30, 2024
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to move forwards with these - given the clear scoping. Will post a clear message in the release notes that errors are now actually errors. Will go through all internal tools to ensure they work as expected

@tobybellwood tobybellwood merged commit 7716346 into main Jun 19, 2024
1 check passed
@tobybellwood tobybellwood deleted the additional-error-handling branch June 19, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants