Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update notification resolvers #3748

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix: update notification resolvers #3748

merged 1 commit into from
Jun 24, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

#3424 had a copypasta error in the update sql, this just fixes that up

@shreddedbacon shreddedbacon requested a review from CGoodwin90 June 24, 2024 02:51
@shreddedbacon shreddedbacon marked this pull request as ready for review June 24, 2024 02:51
@shreddedbacon shreddedbacon added this to the 2.20.0 milestone Jun 24, 2024
CGoodwin90
CGoodwin90 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@CGoodwin90 CGoodwin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, good catch!

tobybellwood
tobybellwood approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops - sorry, that slipped through, nice pickup

@tobybellwood tobybellwood merged commit fbb1563 into main Jun 24, 2024
1 check passed
@tobybellwood tobybellwood deleted the fix-update-notifications branch June 24, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGoodwin90 CGoodwin90 CGoodwin90 approved these changes

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shreddedbacon @tobybellwood @CGoodwin90