Change: check expiration of legacy tokens, reject if necessary #3645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
As we look to phase out the usage of legacy tokens, we need to be able to reject long lived or non-expiring legacy tokens initially.
This introduces two new environment variables that can be set in the API.
LEGACY_EXPIRY_MAX
(default 3600s) - This is the maximum expiry that can be allowed to interact with the APILEGACY_EXPIRY_REJECT
(default false) - This is what controls if a legacy token is rejected based on the checksIf a legacy token has the
exp
field, the remaining duration of the token is calculated against theiss
timestamp. If this duration is greater than theLEGACY_EXPIRY_MAX
, then depending on theLEGACY_EXPIRY_REJECT
setting, it will log, or log and reject the request.If there is no
exp
field on the token, then depending on theLEGACY_EXPIRY_REJECT
setting, it will log, or log and reject the request.