refactor: update backup-handler to use machinery #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
backup-handler-machinery
branch
from
6667635 to
9d9fb3b
Compare
tobybellwood
reviewed
Jun 6, 2024
tobybellwood
reviewed
Jun 6, 2024
shreddedbacon
force-pushed
the
backup-handler-machinery
branch
from
9d9fb3b to
73ce1c1
Compare
shreddedbacon
force-pushed
the
backup-handler-machinery
branch
from
73ce1c1 to
60dcd33
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
Just updates
backup-handlerto use the machinery package for API interactions so that it can leverage the token generation utility machinery provides instead of the older lagoon-cli API package that generated alagoon-commonstoken.This means that backup-handler will generate a short lived token under
backup-handlernow. This is so that #3645 will be able to start to be enforceable generally.Blocked
uselagoon/machinery#54 - Needs to be merged and released so this PR can be updated to use an actual tagged version of machinery than a commit