Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backup handler to ignore namespaces lagoon does not care about #3785

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix: backup handler to ignore namespaces lagoon does not care about #3785

merged 2 commits into from
Aug 5, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jul 31, 2024 •
edited
Loading

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

#3724 introduced machinery, but an issue with the returned data resulting in the backup handler also processing namespaces that lagoon does not know about.

This fixes the issue to use a new specific query crafted just for backups by namespace.

@shreddedbacon shreddedbacon added this to the 2.20.1 milestone Jul 31, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review July 31, 2024 23:55
tobybellwood
tobybellwood approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working

@tobybellwood tobybellwood merged commit d31f3ce into main Aug 5, 2024
1 check passed
@tobybellwood tobybellwood deleted the fix-backup-handler branch August 5, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.20.1
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood