Upgrade to latest LSP client implementation and improve typescript configuration #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig for better node18 and vs code compliance
DavyLandman
force-pushed
the
node-18-esm-upgrade
branch
from
dbf2b9d
to
653fccb
Compare
jurgenvinju
reviewed
Mar 27, 2024
|
Thanks for this upgrade! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things that we've been delaying:
As a side effect this has to increase our minimal VS Code version to 1.82.0 (which was released in June 2023). Since most users are frequently updating VS Code, this should be fine.
This fixes #348 , we could not switch to ESM, as VS Code does not support that, but we could switch to a newer module system, just so we can use the new lsp library.