Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

最低限のコード規約をチェックするお手製CIを追加 #42

Merged
merged 4 commits into from
Nov 26, 2021
Merged

最低限のコード規約をチェックするお手製CIを追加 #42

merged 4 commits into from
Nov 26, 2021

Conversation

meltingrabbit
Copy link
Collaborator

概要

最低限のコード規約をチェックするお手製CIを追加

Issue

詳細

  • えいやで作った規約チェックスクリプトを追加
  • いくつか未だに直しきれていない規約違反があるため，有効化できていないルールもある
  • 今後 既存のフォーマッタを導入したい #41 をしていきたい

検証結果

CIが通ればOK

@meltingrabbit meltingrabbit requested a review from sksat November 26, 2021 08:56
@meltingrabbit meltingrabbit self-assigned this Nov 26, 2021
@meltingrabbit meltingrabbit force-pushed the feature/add_coding_rule_check_ci branch from d02a9d5 to 8cfaa2f Compare November 26, 2021 09:01
@meltingrabbit meltingrabbit requested a review from yngyu November 26, 2021 09:03
@meltingrabbit meltingrabbit merged commit 114781a into develop Nov 26, 2021
@meltingrabbit meltingrabbit deleted the feature/add_coding_rule_check_ci branch November 26, 2021 10:33
@meltingrabbit meltingrabbit mentioned this pull request Dec 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yngyu yngyu yngyu approved these changes

@sksat sksat Awaiting requested review from sksat

Assignees

@meltingrabbit meltingrabbit

Labels
priority::medium priority medium tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @yngyu