Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verboseMode & is_stdout_verbose() check to GODOT_LOG #77

Closed
wants to merge 1 commit into from

Conversation

2shady4u
Copy link
Contributor

This is my suggestion to add output suppression to the FMOD plugin as discussed in #74
I'm using two variables for following reason:

  • Sometimes I want to see the FMOD output in the console without putting my Godot editor in verbose mode. Setting verbose stdout in Godot dumps to much other stuff to the console that might not be relevant to the matter at hand (= debugging FMOD issues)

  • When running Godot in verbose mode (-v) you evidently want all FMOD output to be dumped to the console without having to set the verbose_mode to true.

Other proposals/modifications by owners are ofc welcome!

@bitbrain
Copy link
Contributor

LGTM - do we want to add some documentation, too? Maybe to the README for now?

@CedNaru
Copy link
Member

CedNaru commented Nov 16, 2021

I think I would prefer going beyond and have 3 modes for Fmod.
VERBOSE, INHERITED, QUIET.
Inherited would basically follow Godot's settings and would be the default value.

@2shady4u
Copy link
Contributor Author

I think I would prefer going beyond and have 3 modes for Fmod. VERBOSE, INHERITED, QUIET. Inherited would basically follow Godot's settings and would be the default value.

That's a good idea! I like this

@bitbrain
Copy link
Contributor

@2shady4u Any progress with this?

@2shady4u
Copy link
Contributor Author

2shady4u commented Jul 28, 2022

I think that this PR has outlived its welcome.
Additionally, I'm currently not in a good position (time-wise) to finish this PR.
Now with the upcoming port to 4.0, most of the macro functions will become obsolete.

If anyone is willing to implement this in a future PR, please feel free to check out this PR for inspiration.

@2shady4u 2shady4u closed this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants