Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CI from fork #94

Closed
wants to merge 1 commit into from
Closed

Conversation

2shady4u
Copy link
Contributor

@2shady4u 2shady4u commented Nov 5, 2021

Test to see if I can trigger CI with secrets from my fork

@bitbrain
Copy link
Contributor

bitbrain commented Nov 5, 2021

Reading this thread https://git.luolix.topmunity/t/make-secrets-available-to-builds-of-forks/16166/34 other people seem to have trouble doing the same. Do we have any example on this project where someone raised a PR from a fork and it was built successfully?

@bitbrain
Copy link
Contributor

bitbrain commented Nov 5, 2021

Ah yes, this one #77

@2shady4u
Copy link
Contributor Author

2shady4u commented Nov 5, 2021

Ah yes, this one #77

Yeah, but that's because we were still using pull_request_target at that time.
Recently we switched to pull_request in all_builds.yml (#89) and after that builds don't succeed any longer.
This change was done such that PR are correctly tested.
Before that the CI of a PR ran on the latest master commit and NOT on the PR's commit which destroyed the entire purpose of having CI in a PR at all 🤷

We'll maybe have to implement something like this to fix this issue:
https://github.com/imjohnbo/ok-to-test

I currently dont see any other solutions to this problem :/

@bitbrain
Copy link
Contributor

bitbrain commented Nov 5, 2021

I am wondering: couldn't we do some trickery by creating a branch off master with the same name as the fork branch, then merging the changes from the fork branch into this repository and then simply run the build/test on that branch (which belongs to this repo) so it can use the secrets from this repo, not from the forks? We would just need to ensure that branches are cleaned up properly after merging, also conflicting remote branch names from different forks might cause weirdness.

@bitbrain
Copy link
Contributor

bitbrain commented Nov 9, 2021

I created #95 to track this issue.

@2shady4u 2shady4u closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants