Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA CICD #1449

Merged
merged 139 commits into from
Apr 13, 2020
Merged

Add GHA CICD #1449

merged 139 commits into from
Apr 13, 2020

Conversation

rivy
Copy link
Member

@rivy rivy commented Jan 29, 2020

  • adds GitHub-Actions CICD workflow (includes arm-linux, x86-linux, macos, and windows builds/testing)
  • builds / tests successfully locally and on all CI hosts; fixed few minor testing issues
  • cargo fmt done to allow for style testing in CICD
  • minor CICD updates/fixes
  • feature system refactored for easier expansion and cross-platform uses
  • cargo build compiles successfully on all platforms (compiling the set of uutils which are fully cross-platform)
  • cargo make enhanced...
    • cargo make ... builds the full host platform util set into uutils
    • cargo make utils [UTIL]... ... builds individual utils
    • cargo make features FEAT [FEAT]... ... builds uutils using specified features
    • cargo make help shows all additional available sub-commands

... PR is on top of fix.lints (PR #1443 )
(14 commits => rivy/rs.coreutils@fix.lints...rivy:add.cicd)

Note: you'll likely have to enable GitHub actions to get the CICD running.

Fixes: #1419
Fixes: #1366
Fixes: #1364
Fixes: #1361
Fixes: #1187
Fixes: #1122
Fixes: #1102

Fixes: #1433 (?; at least a start of a usable cargo make)
Fixes: #1174 (addresses default build issue)

.# [why]

`mem::ununitialized()` is deprecated as of rust v1.39.0.

And this use is likely a premature optimization attempting to avoid
initializing the byte array to 0, which is usually a *very* fast operation.

* ref: <https://github.com/rust-lang/rust/blob/master/RELEASES.md>
* ref: <https://stackoverflow.com/questions/3654905/faster-way-to-zero-memory-than-with-memset>
rivy added 14 commits April 12, 2020 16:56
…e if clause)'

.# [why]

The initial refactoring/repair led to comments within if conditions which is
objectionable to some of the devs. So, this changes the refactor to completely split
the if clauses into separate if statements (with corresponding commentary).

Note: this refactor is "less mechanical" and does increase the risk of changing the
actual effect of the code. But the change is small and the tests are passing.
…stream

- fixes musl (no-utmpx) build bug
- fixes failing windows real{link,path} tests
@sylvestre
Copy link
Sponsor Contributor

@rivy still planning to land it today?

@rivy
Copy link
Member Author

rivy commented Apr 13, 2020

@rivy still planning to land it today?

Yes, any objections? ... or any change requests?

@sylvestre
Copy link
Sponsor Contributor

nope, au contraire :)
I think it is time now!

@rivy
Copy link
Member Author

rivy commented Apr 13, 2020

Alright, I'm doing a test merge right now on my repository; it should complete testing in about 15 minutes. If the test completes without errors, I merge it.

I think the master branch here might still have a FOSSA error, but I haven't been able to get a hold of @Arcterus to turn it off or give permissions to do so here or on the FOSSA website.

But at least PRs based on the new master should all be able to test successfully.

@rivy rivy merged commit 08a2cd0 into uutils:master Apr 13, 2020
@rivy
Copy link
Member Author

rivy commented Apr 13, 2020

Merged to master, all tests passed (including FOSSA). 🎉

I've just push a 0.0.1 tag to initiate a build creating a github release with packaged builds for all platforms. Let's see how that goes now. 🤞

@ArniDagur
Copy link
Contributor

ArniDagur commented Apr 13, 2020

Woohoo! Thanks for you hard work @rivy

@sylvestre
Copy link
Sponsor Contributor

bravo, you can be proud :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants