Add GHA CICD #1449
Add GHA CICD #1449
Commits on Jan 28, 2020
-
refactor ~ remove unneeded mem::uninitialized() code
.# [why] `mem::ununitialized()` is deprecated as of rust v1.39.0. And this use is likely a premature optimization attempting to avoid initializing the byte array to 0, which is usually a *very* fast operation. * ref: <https://github.com/rust-lang/rust/blob/master/RELEASES.md> * ref: <https://stackoverflow.com/questions/3654905/faster-way-to-zero-memory-than-with-memset>
-
-
-
refactor/polish ~ fix
cargo clippycomplaints (default/tests => `le……t ... = if ...`)
-
refactor/polish ~ fix
cargo clippycomplaints (`while let ... = som……e` => `for ... in`)
-
-
-
-
-
refactor/polish ~ fix
cargo clippycomplaints (simplify enum elemen……t names/InteractiveMode)
-
refactor/polish ~ fix
cargo clippycomplaints (simplify enum elemen……t names/NumberMode)
-
-
-
refactor/polish ~ fix
cargo clippycomplaints (allow comparison_cha……in {for f64 comparisons}) -
refactor/polish ~ fix
cargo clippycomplaints (allow map_clone).# [why] Although `copied()` is preffered, it was not stabilized until rust v1.35.0. So, 'map_clone' is allowed instead of increasing MinSRV to v1.35.0. * ref: https://github.com/rust-lang/rust/blob/master/RELEASES.md
-
refactor/polish ~ fix
cargo clippycomplaints (allow range_plus_one……; `clippy` bug workaround) * ref: <rust-lang/rust-clippy#4898>
-
refactor/polish ~ fix
cargo clippycomplaints (allow unreadable_lit……eral {for dynamic code}) -
refactor/polish ~ fix
cargo clippycomplaints (allow deprecated mem……::uninitialized) .# [why] `std::mem::MaybeUninit` is likely preffered. But `MaybeUninit` was not stabilized until rust v1.36.0 and conversion from `mem::uninitialized` is not obviously straight-forward at the moment. So, 'std::mem::uninitialized' is allowed instead of increasing MinSRV to v1.36.0. * ref: https://github.com/rust-lang/rust/blob/master/RELEASES.md
Commits on Feb 9, 2020
-
maint/build ~ refactor feature strategy (allows simple
cargo build……on all platforms) and easier cross-targeted builds
Commits on Apr 11, 2020
-
-
-
-
-
-
fix forced MinSRV increase (using locked 'backtrace' version)
- hotfix transitive bug in 'failure' forcing MinSRV increase to rust v1.33.0 by pinning 'backtrace' to <= 0.3.31 .# [why] 'failure' was using 'backtrace' `version = "0.3.3"`, which by semantic version auto-upgrade was pulling in 'backtrace' > v0.3.30 (specifically, v0.3.40 most recently). 'backtrace' v0.3.31 introduces use of `#[cfg(target_vendor = ...)]` which requires rust v1.33.0. So, 'backtrace' is forcing an upgrade of MinSRV to rust v1.33.0 with the change from backtrace v0.3.30 to backtrace v0.3.31. Technically, by being less than v1.0.0, 'backtrace' has no semantic version requirement. And there is debate about whether increasing MinSRV is a semantic change. But, in my strong opinion, breaking our MinSRV statement is definitely a semantic change. * ref: <https://github.com/rust-lang/rust/blob/master/RELEASES.md>
-
-
refactor/polish ~ fix
cargo clippycomplaints (missing_safety_doc; ……with ToDO for safety note)
-
refactor/polish ~ fix
cargo clippycomplaints (deprecated std::erro……r::Error::description)
-
Commits on Apr 12, 2020
-
maint/CICD ~ improve PR support for AppVeyor CI builds
- change branch and follow-up commit checkout logic to avoid build failures for PR edge cases - note: final branch pointer is still preserved to support correct code coverage attribution
-
-
-
-
-
-
maint/build ~ refactor dependency specifications (sorted, single line…
…s) of 'Cargo.toml'
-
-
refactor ~ change repair of 'fix
cargo clippycomplaints (fatal/sam……e if clause)' .# [why] The initial refactoring/repair led to comments within if conditions which is objectionable to some of the devs. So, this changes the refactor to completely split the if clauses into separate if statements (with corresponding commentary). Note: this refactor is "less mechanical" and does increase the risk of changing the actual effect of the code. But the change is small and the tests are passing.
-
-
-
-
-
Commits on Apr 13, 2020
-
update ~ (maint!) use fixed/patched uucore (v0.0.2); await upgrade up…
…stream - fixes musl (no-utmpx) build bug - fixes failing windows real{link,path} tests