feat: initial donor dropoff view #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/src/components/pages/Dropoff/components/DropoffCard.tsx
Outdated
Show resolved
Hide resolved
hanlinc27
force-pushed
the
feat/donor-view
branch
from
16a8fc5 to
8a3d2b0
Compare
Shehryar21
requested changes
Nov 16, 2021
| @@ -100,112 +99,109 @@ const AccountDetails = ({ | |||
| } | |||
|
|
|||
| return ( | |||
| <> | |||
| <Header /> | |||
There was a problem hiding this comment.
I am guessing this header would be added in Anne's PR.
There was a problem hiding this comment.
yeah I made a comment in #37 so just depends what gets merged first
frontend/src/components/pages/Dropoff/components/DropoffCard.tsx
Outdated
Show resolved
Hide resolved
* feat: add getDonorByUserID service * fix: get donor service
hanlinc27
force-pushed
the
feat/donor-view
branch
from
461d633 to
5130ad6
Compare
4 tasks
Shehryar21
requested changes
Nov 17, 2021
| borderRadius="8px" | ||
| > | ||
| <Box pl="6" pr="6" pb="6" pt="4"> | ||
| <HStack spacing="10"> |
There was a problem hiding this comment.
I believe if you touch anywhere in the card, it should also lead to the edit page, so I guess add the onClick function for box as well?
There was a problem hiding this comment.
Are you sure? What's the purpose of the menu button for edit then?
frontend/src/components/pages/Dashboard/components/DropoffCard.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/pages/Dashboard/EditDashboardSchedule.tsx
Outdated
Show resolved
Hide resolved
Shehryar21
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Donor Dropoff View
Implementation description
<Header/>component to be mounted inApp.tsxto avoid rerenders/dropoffand the donor schedule details at/dropoff/:id?donorId=getDonorByUserIdendpoint: feat: addgetDonorByUserIdservice #38https://user-images.githubusercontent.com/19617248/141862607-29e54fe7-b34d-44c8-b687-e406749a631e.mp4
6ed9983e-1e58-497d-9ca6-d137bef2cb92.mp4
Steps to test
POSTa few schedules in order to see it populated, test out buttons:{ "donorId": 2, "categories": ["Non-perishables"], "size": "large", "pickupLocation": "University of Waterloo", "startTime": "Mon Nov 15 2021 22:19:23", "endTime": "Tues Nov 16 2021 22:19:25", "status": "Pending", "isPickup": true, "volunteerNeeded": true, "frequency": "Weekly on Monday", "notes": "These are copied notes" }What should reviewers focus on?