Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: update header and drawer #37

Merged
merged 9 commits into from
Nov 18, 2021
Merged

style: update header and drawer #37

merged 9 commits into from
Nov 18, 2021

Conversation

annechung
Copy link
Contributor

@annechung annechung commented Nov 15, 2021 •
edited
Loading

Notion ticket link

Update Header and Drawer Component

Implementation description

  • add logos (unofficial logos, assets will be received soon according to binal)
  • update header/drawer to match mobile and desktop designs
  • create different views for logged in vs. logged out

Mobile Header

Mobile Drawer (Logged In)

Mobile Drawer (Logged Out)

Desktop Header (Logged In)
image

Desktop Header (Logged Out)
image

Steps to test

  1. Run frontend and view the mobile/desktop versions for the logged out view by resizing the window
  2. To view logged in view, hardcode a value for authenticatedUser in the code in Header.tsx 🙃

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

annechung
annechung commented Nov 15, 2021
View reviewed changes
frontend/src/index.css Outdated
monospace;
}

.chakra-modal__content {
width: 220px !important;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for the drawer component, wasn't able to find a different way to set the width

@annechung annechung requested a review from a team November 15, 2021 06:40
hanlinc27
hanlinc27 requested changes Nov 15, 2021
View reviewed changes
Copy link
Member

@hanlinc27 hanlinc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the responsiveness looks great!! 🥳

@hanlinc27 hanlinc27 changed the title feat: update header and drawer style: update header and drawer Nov 16, 2021
@hanlinc27 hanlinc27 mentioned this pull request Nov 16, 2021
Merged
@annechung
Copy link
Contributor Author

@hanlinc27 cleaned up the code a bit, thanks for the suggestions :D

hanlinc27
hanlinc27 approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@hanlinc27 hanlinc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@annechung annechung merged commit d3974eb into main Nov 18, 2021
@annechung annechung deleted the feat/header branch November 18, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanlinc27 hanlinc27 hanlinc27 approved these changes

Assignees
No one assigned
Labels
changes requested frontend Frontend change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annechung @hanlinc27