Delete SMTP Server #256
Merged
Delete SMTP Server #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leostera
commented
Nov 10, 2023
leostera
commented
Nov 10, 2023
mabiede
reviewed
Nov 10, 2023
mabiede
reviewed
Nov 10, 2023
mabiede
reviewed
Nov 10, 2023
mabiede
requested changes
Nov 13, 2023
mabiede
reviewed
Nov 13, 2023
|
I'll create an integration test for the SMTP:
|
leostera
force-pushed
the
feat/delete-smtp-servers
branch
from
0a667eb
to
7e71d6d
Compare
leostera
force-pushed
the
feat/delete-smtp-servers
branch
from
7e71d6d
to
dd7ea95
Compare
5 tasks
mabiede
reviewed
Nov 17, 2023
leostera
force-pushed
the
feat/delete-smtp-servers
branch
4 times, most recently
from
01ac59f
to
0c25049
Compare
fix: clear email worker cache when deleting SMTP servers feat: add route for deleting smtp servers from root app chore: delete unused type test: update and delete smtp servers In order to test the system events created in it, we need to either loosen up the comparison relation (so that we can skip comparison of system events by id), or allow for fixing the system event ids that will be used so the assertions are meaningful. Also the update test has been reintroduced after fixing this. fix: casing/typos on email server i18n test: add integration tests for smtp auth
leostera
force-pushed
the
feat/delete-smtp-servers
branch
from
0c25049
to
dd8ee3c
Compare
mabiede
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks! 👋🏼 Here's a PR sketching support for deleting SMTP servers.
It includes:
SmtpDeletedEventpool_smtptable by idSmtp.DeletecommandSmtp.AccessguardSmtp.deletecontroller/admin/settings/smtp/:id/deleterouteMissing a few tests, and probably isn't entirely fitting the repo-style yet. I have some comments but we can discuss them over a call first.
Happy to address/amend anything, just let me know 🙌🏼