-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Experiment Filters for Invitations #258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leostera
force-pushed
the
feat/add-experiment-filters-1
branch
3 times, most recently
from
November 21, 2023 03:51
e7ebde3
to
2ad596a
Compare
leostera
force-pushed
the
feat/add-experiment-filters-1
branch
from
November 23, 2023 04:10
3a2791f
to
cb90b56
Compare
leostera
commented
Nov 23, 2023
leostera
commented
Nov 23, 2023
leostera
commented
Nov 23, 2023
leostera
commented
Nov 23, 2023
leostera
commented
Nov 23, 2023
leostera
commented
Nov 23, 2023
leostera
changed the title
feat: Add Experiment Filters for Assignments and Invitations
feat: Add Experiment Filters for Invitations
Nov 23, 2023
@mabiede feel free to squash and remove some of the commit messages in the process :) |
mabiede
requested changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks. Added a few comments about left overs and adjustments to the consistency
4 tasks
mabiede
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working here, opening to gather notes. So far:
hardcoded
field for InvitationsAdd support for Assignments– we will add assignment filtering in the next PRLike #256 this PR builds on to of #257, so once #257 is merged, I'll clean up the history here.