Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Experiment Filters for Assignments #267

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

leostera
Copy link
Collaborator

@leostera leostera commented Nov 24, 2023

Still working here, opening to gather notes. So far:

  • New hardcoded field for Assignments
  • Adds a subquery for listing assignments
  • Creates a temporary table for Assignments
  • Create integration test for different filters

This PR builds on #258 so once its merged, I'll clean up the history here.

@leostera leostera marked this pull request as draft November 24, 2023 06:32
@leostera leostera force-pushed the feat/add-experiment-filters-2 branch from 57b0515 to 9049395 Compare November 24, 2023 07:46
* add indices to temporary tables
@leostera leostera force-pushed the feat/add-experiment-filters-2 branch from 00baffa to f5598a5 Compare November 24, 2023 17:09
@leostera leostera marked this pull request as ready for review November 24, 2023 17:10
pool/app/filter/repo/repo.ml Show resolved Hide resolved
pool/test/filter_assignment_tests.ml Outdated Show resolved Hide resolved
@mabiede mabiede merged commit 8422630 into main Nov 29, 2023
5 checks passed
@leostera leostera deleted the feat/add-experiment-filters-2 branch November 30, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants