Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update flow to 24.3-SNAPSHOT #5683

Merged
merged 2 commits into from
Nov 17, 2023
Merged

chore: update flow to 24.3-SNAPSHOT #5683

merged 2 commits into from
Nov 17, 2023

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Nov 9, 2023 •
edited
Loading

@vursen vursen requested a review from ZheSun88 November 9, 2023 10:57
@ZheSun88 ZheSun88 enabled auto-merge (squash) November 9, 2023 10:59
@ZheSun88
Copy link
Contributor

ZheSun88 commented Nov 9, 2023

i think this error is not a random failure.

Caused by: java.lang.AssertionError: Error message in browser log: [2023-11-09T13:58:32.139Z] [SEVERE] http://172.16.1.174:8080/VAADIN/build/FlowClient-60ad8908.js 0:4738 Uncaught TypeError: Cannot read properties of undefined (reading 'setDefaultHideDelay')

@vursen vursen force-pushed the chore/update-flow-snapshot branch from 903eb8f to c74187c Compare November 10, 2023 11:50
@vursen
Copy link
Contributor Author

vursen commented Nov 13, 2023 •
edited
Loading

The build failures are caused by a regression in Flow: vaadin/flow#18016

@vursen vursen mentioned this pull request Nov 14, 2023
Merged
1 task
@vursen
Copy link
Contributor Author

vursen commented Nov 16, 2023 •
edited
Loading

The build failures are caused by a regression in Flow: vaadin/flow#18016

FYI, our further investigation together with the Flow team showed that it wasn't a regression, but a bug in TooltipConfiguration that has become visible after Flow enabled error logging in production in 24.3.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ZheSun88
Copy link
Contributor

there are still two tests failed

com.vaadin.flow.component.dialog.tests.DialogWithShortcutIT.dialogWithShortcutAndAllowBrowserDefault_containsInput_shortcutDoesNotBlockInput[any_Chrome_]
com.vaadin.flow.component.dialog.tests.DialogWithShortcutIT.dialogWithShortcut_containsInput_shortcutDoesNotBlockInput[any_Chrome_]

@tomivirkki
Copy link
Member

tomivirkki commented Nov 16, 2023 •
edited
Loading

there are still two tests failed

See vaadin/flow#18048

@ZheSun88 ZheSun88 merged commit 6af14e6 into main Nov 17, 2023
@ZheSun88 ZheSun88 deleted the chore/update-flow-snapshot branch November 17, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZheSun88 ZheSun88 ZheSun88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vursen @ZheSun88 @tomivirkki