fix: support serialization of Vaadin scoped beans #20394
Conversation
Makes sure that VaadinSession and UI thread locals are available during both serialization and deserialization, to allow other libraries to perform inspection and injection of Vaadin scoped beans. Also refactors VaadinRouteScope to be independent from VaadinService when fetching RouteScopeOwner annotation for the bean, and replaces VaadinSession.unlock() calls with direct access to the lock instance to prevent unwanted push during bean lookup. Fixes #19967 Part of vaadin/kubernetes-kit#140
Vaadin scoped beans requires VaadinSession and UI thread locals to be set in order to lookup beans. This change tracks Vaadin scoped beans during serialization and makes sure that required thread locals are set during deserialization. The serialVersionUID added to TransientDescriptor should keep it compatible with older version, preventing deserialization of previous data to fail. Fixes #140 Requires vaadin/flow#20394
| } | ||
| } | ||
|
|
||
| @Serial |
There was a problem hiding this comment.
Could we add @Serial to the same methods in VaadinSession class?
There was a problem hiding this comment.
Yeah, makes sense, even though it is not required
| @@ -369,10 +355,52 @@ private NavigationListener getNavigationListener() { | |||
|
|
|||
| } | |||
|
|
|||
| private record ObjectWithOwner(Object object, RouteScopeOwner owner) { | |||
There was a problem hiding this comment.
Does this need implements Serializable?
There was a problem hiding this comment.
No. The object is not stored anywhere. It is only used as a carrier of information for other logics.
Currently, custom logic for handling scoped beans during deserialization is implemented only in Kubernetes Kit and only for Spring. |
|
Makes sure that VaadinSession and UI thread locals are available during both serialization and deserialization, to allow other libraries to perform inspection and injection of Vaadin scoped beans. Also refactors VaadinRouteScope to be independent from VaadinService when fetching RouteScopeOwner annotation for the bean, and replaces VaadinSession.unlock() calls with direct access to the lock instance to prevent unwanted push during bean lookup. Fixes #19967 Part of vaadin/kubernetes-kit#140 Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
|
Hi @mcollovati and @mshabarov, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? |
Makes sure that VaadinSession and UI thread locals are available during both serialization and deserialization, to allow other libraries to perform inspection and injection of Vaadin scoped beans. Also refactors VaadinRouteScope to be independent from VaadinService when fetching RouteScopeOwner annotation for the bean, and replaces VaadinSession.unlock() calls with direct access to the lock instance to prevent unwanted push during bean lookup. Fixes #19967 Part of vaadin/kubernetes-kit#140 Co-authored-by: Marco Collovati <marco@vaadin.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Makes sure that VaadinSession and UI thread locals are available during both serialization and deserialization, to allow other libraries to perform inspection and injection of Vaadin scoped beans. Also refactors VaadinRouteScope to be independent from VaadinService when fetching RouteScopeOwner annotation for the bean, and replaces VaadinSession.unlock() calls with direct access to the lock instance to prevent unwanted push during bean lookup. Fixes #19967 Part of vaadin/kubernetes-kit#140 Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Makes sure that VaadinSession and UI thread locals are available during both serialization and deserialization, to allow other libraries to perform inspection and injection of Vaadin scoped beans. Also refactors VaadinRouteScope to be independent from VaadinService when fetching RouteScopeOwner annotation for the bean, and replaces VaadinSession.unlock() calls with direct access to the lock instance to prevent unwanted push during bean lookup. Fixes #19967 Part of vaadin/kubernetes-kit#140 Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Description
Makes sure that VaadinSession and UI thread locals are available during both serialization and deserialization, to allow other libraries to perform inspection and injection of Vaadin scoped beans.
Also refactors VaadinRouteScope to be independent from VaadinService when fetching RouteScopeOwner annotation for the bean, and replaces VaadinSession.unlock() calls with direct access to the lock instance to prevent unwanted push during bean lookup.
Fixes #19967
Part of vaadin/kubernetes-kit#140
Type of change
Checklist
Additional for
Featuretype of change