Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require network id in every tx #99

Closed
wants to merge 1 commit into from

Conversation

davidmisiak
Copy link
Collaborator

From now on, each transaction body will contain network_id (see vacuumlabs/trezor-firmware#71).

TODO:

  • decide what to do with files in test/integration/trezor/cli and test cases in test/integration/trezor/node/tx.js (currently, one test case is updated, but we're not sure if this is what we want to do)
  • Ledger support

@gabrielKerekes gabrielKerekes changed the base branch from gk/multisig to ja/multisig November 22, 2021 12:47
@gabrielKerekes gabrielKerekes changed the base branch from ja/multisig to gk/multisig November 22, 2021 12:47
@davidmisiak
Copy link
Collaborator Author

The specification has changed (network id will be optional), rendering this PR obsolete.

@janmazak janmazak deleted the dm/require-network-id branch February 16, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant