-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cardano): add support for alonzo transactions #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. I noticed a few minor issues though 😉
I'm not sure about show_warning_tx_output_contains_data_hash
- the name and how the hash is displayed. I know it's mentioned in the TODOs, I'm just mentioning it here as another reminder.
0027ea9
to
497d639
Compare
b173249
to
ec33454
Compare
ec33454
to
0aab131
Compare
0aab131
to
f591342
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed all the source code. I haven't tested it yet nor have I looked at the tests. I will do this tomorrow. So far I haven't found any major issues. Mostly just some refactoring suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the tests, tried signing a few transactions and checked their bodies. Seems to work as currently expected 👍
a0cf806
to
2c90304
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good for now. Please fix my last comments, squash the fixups and then I think we should both go through it and test it once more to verify that all indeed is good.
2c90304
to
48bf169
Compare
700d4ad
to
9c46518
Compare
9c46518
to
bc5c0e8
Compare
bc5c0e8
to
07c246a
Compare
I just realised that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit pick and I would perhaps also add a test to sign_tx.plutus.json
with a script payment address output and no datum hash to signify that it indeed should pass.
Hello, new to open source development. But Cardano just launched 3 DEXs and there is no hardware support for Alonzo smart contracts yet on the Trezor model T. Been tracking this issue for a while and noticed it's been sitting here. Is there someway i can help contribute in order to merge this feature? It's really really needed. Thanks. |
@stefanobieler |
b7eac0a
to
0d5ff74
Compare
bfebbbc
to
ef292c0
Compare
ef292c0
to
6eb2fd0
Compare
Merged in trezor#2114. |
New features:
network_id
is optionally serialized in tx bodydatum_hash
may be present in outputs ifORDINARY_TRANSACTION
,MULTISIG_TRANSACTION
orPLUTUS_TRANSACTION
signing mode is used and the output address contains a script hashscript_data_hash
may be present ifORDINARY_TRANSACTION
,MULTISIG_TRANSACTION
orPLUTUS_TRANSACTION
signing mode is usedPLUTUS_TRANSACTION
signing mode, which allows signing transactions with collateral inputs and required signerskey_hash
inPLUTUS_TRANSACTION