feat(cardano): add map key canonical order validation #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielKerekes
force-pushed
the
cardano-multisig
branch
4 times, most recently
from
22cb3fe to
b47a177
Compare
gabrielKerekes
requested changes
Aug 24, 2021
There was a problem hiding this comment.
Apart from the withdrawals which need to be fixed, looks good. Please use fixup commits when resolving the comments.
davidmisiak
force-pushed
the
cardano-map-keys-canonical-ordering
branch
from
862fa9e to
f1f217f
Compare
davidmisiak
force-pushed
the
cardano-map-keys-canonical-ordering
branch
from
f1f217f to
ac90598
Compare
gabrielKerekes
requested changes
Sep 4, 2021
gabrielKerekes
approved these changes
Sep 7, 2021
|
Closing this in favor of #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.