l10n: Correctly setup the locales #8
Conversation
| # Provide a path of the directory where translation binary files (*.mo) are located | ||
| config_data.set_quoted('LOCALEDIR', get_option('prefix') / get_option('localedir')) | ||
| # Provide translation domain name | ||
| config_data.set_quoted('GETTEXT_PACKAGE', meson.project_name()) |
There was a problem hiding this comment.
If this is the same as project ID can we just assume this is also always the same as application ID? It feels like kinda overkill to use a config file for this if we know it's equal to a variable we're already using in the application class
There was a problem hiding this comment.
If this is the same as project ID can we just assume this is also always the same as application ID?
Hmm, I don't think so, because I think it's by chance that the GETTEXT_PACKAGE in the config file is same as the application ID in this example.
We can set a value to GETTEXT_PACKAGE that is different from the application ID. And in that case, it's meson.build that knows the original value of GETTEXT_PACKAGE, as you can see at ryonakano@5d4c2e1. So I think it's reasonable to set GETTEXT_PACKAGE as a configuration data here and don't think it's overkill, even if these values are equal.
Fixes #4
I annotated some codes because this is a example code