refactor: create root level HelmConfig struct which applies to all HelmReleases #345
Conversation
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 48.58% 48.94% +0.35%
==========================================
Files 22 22
Lines 1274 1275 +1
==========================================
+ Hits 619 624 +5
+ Misses 587 584 -3
+ Partials 68 67 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| // Name of the Helm chart. | ||
| Name string `json:"name" yaml:"name"` | ||
|
|
||
| // HelmConfig defines the configuration for a Helm repository. |
There was a problem hiding this comment.
Repository refers to the name of a chart within a registry. So this should say "for a Helm registry".
| Name string `json:"name" yaml:"name"` | ||
|
|
||
| // HelmConfig defines the configuration for a Helm repository. | ||
| type HelmConfig struct { | ||
| // Repository URL of the Helm chart. | ||
| Repository string `json:"repository" yaml:"repository"` |
There was a problem hiding this comment.
Propose to rename this Registry w/ comment: "Registry is the URL of a Helm registry"
There was a problem hiding this comment.
Because repository can't be configured globally - it varies for each chart.
| Chart HelmChart `json:"chart" yaml:"chart"` | ||
| // Name of the Helm chart. | ||
| Name string `json:"name" yaml:"name"` | ||
|
|
There was a problem hiding this comment.
We need to track repository here in addition to the name:
// Repository containing the Helm chart.
Repository string `json:"repository" yaml:"repository"`Structure of Helm URI: <registry>/<repository>/<chart>
ahmad-ibra
force-pushed
the
main
branch
2 times, most recently
from
9475765
to
6ece95b
Compare
Issue
First step into resolving
Description
In an effort to simplify the TUI prompts in validatorctl to not require lots of re-prompts for the helm configuration, we first need to refactor our helm related structs.
The proposed structure would be this:
ValidatorConfigSpec.HelmConfigdefines the helm repository configuration that would be used to pull all plugin chartsValidatorConfigSpec.Pluginshas been simplifies to only specify the charts name, version, and values.