Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Simplify Helm registry prompts #100

Closed
TylerGillson opened this issue Jul 25, 2024 · 0 comments · Fixed by #115
Closed

🎨 Simplify Helm registry prompts #100

TylerGillson opened this issue Jul 25, 2024 · 0 comments · Fixed by #115
Assignees
Labels
refactoring Refactoring / tech debt

Comments

@TylerGillson
Copy link
Member

TylerGillson commented Jul 25, 2024

Prompt for Helm registry input ONCE, with the assumption that all charts are in the same registry. This is a reasonable assumption and simplifies the TUI flow substantially.

@TylerGillson TylerGillson added the refactoring Refactoring / tech debt label Jul 25, 2024
@dosubot dosubot bot added the enhancement Enhancement to an existing feature label Jul 25, 2024
@TylerGillson TylerGillson removed the enhancement Enhancement to an existing feature label Jul 25, 2024
@ahmad-ibra ahmad-ibra self-assigned this Jul 25, 2024
ahmad-ibra added a commit to validator-labs/validator that referenced this issue Jul 31, 2024
…lmReleases (#356)

## Issue
First step into resolving
- validator-labs/validatorctl#100

## Description
In an effort to simplify the TUI prompts in validatorctl to not require
lots of re-prompts for the helm configuration, we first need to refactor
our helm related structs.

The proposed structure would be this:

- `ValidatorConfigSpec.HelmConfig` defines the helm registry
configuration that would be used to pull all plugin charts
- `ValidatorConfigSpec.Plugins` has been simplifies to only specify the
charts repository, name, version, and values.

Along side this change, I updated the `reviewable-ext` make target to
also update the CRDs in the validator helm chart
ahmad-ibra added a commit to validator-labs/validator that referenced this issue Aug 1, 2024
…eleases (#356)

First step into resolving
- validator-labs/validatorctl#100

In an effort to simplify the TUI prompts in validatorctl to not require
lots of re-prompts for the helm configuration, we first need to refactor
our helm related structs.

The proposed structure would be this:

- `ValidatorConfigSpec.HelmConfig` defines the helm registry
configuration that would be used to pull all plugin charts
- `ValidatorConfigSpec.Plugins` has been simplifies to only specify the
charts repository, name, version, and values.

Along side this change, I updated the `reviewable-ext` make target to
also update the CRDs in the validator helm chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring / tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants