-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Simplify Helm registry prompts #100
Labels
refactoring
Refactoring / tech debt
Comments
ahmad-ibra
added a commit
to validator-labs/validator
that referenced
this issue
Jul 31, 2024
…lmReleases (#356) ## Issue First step into resolving - validator-labs/validatorctl#100 ## Description In an effort to simplify the TUI prompts in validatorctl to not require lots of re-prompts for the helm configuration, we first need to refactor our helm related structs. The proposed structure would be this: - `ValidatorConfigSpec.HelmConfig` defines the helm registry configuration that would be used to pull all plugin charts - `ValidatorConfigSpec.Plugins` has been simplifies to only specify the charts repository, name, version, and values. Along side this change, I updated the `reviewable-ext` make target to also update the CRDs in the validator helm chart
ahmad-ibra
added a commit
to validator-labs/validator
that referenced
this issue
Aug 1, 2024
…eleases (#356) First step into resolving - validator-labs/validatorctl#100 In an effort to simplify the TUI prompts in validatorctl to not require lots of re-prompts for the helm configuration, we first need to refactor our helm related structs. The proposed structure would be this: - `ValidatorConfigSpec.HelmConfig` defines the helm registry configuration that would be used to pull all plugin charts - `ValidatorConfigSpec.Plugins` has been simplifies to only specify the charts repository, name, version, and values. Along side this change, I updated the `reviewable-ext` make target to also update the CRDs in the validator helm chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prompt for Helm registry input ONCE, with the assumption that all charts are in the same registry. This is a reasonable assumption and simplifies the TUI flow substantially.
The text was updated successfully, but these errors were encountered: