Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/topics/performance-on-cpu.md has unneeded reference to previous project #124

Closed
stockholmux opened this issue May 30, 2024 · 0 comments · Fixed by #153
Closed

/topics/performance-on-cpu.md has unneeded reference to previous project #124

stockholmux opened this issue May 30, 2024 · 0 comments · Fixed by #153

Comments

@stockholmux
Copy link
Member

In pre-publishing review (#91), I found the following issue:

$ make REDIS_CFLAGS="-g -fno-omit-frame-pointer"

REDIS_CFLAGS is still in the make file, but it's worth moving to SERVER_CFLAGS
@stockholmux stockholmux mentioned this issue May 30, 2024
Open
70 tasks
zuiderkwast added a commit to zuiderkwast/valkey-doc that referenced this issue Jul 3, 2024
@zuiderkwast
performance-on-cpu.md remove refs to redis, valkey-io#124
4257377 
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast zuiderkwast mentioned this issue Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doc review fixes zuiderkwast/valkey-doc
1 participant
@stockholmux