Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc review fixes #153

Merged
merged 19 commits into from
Jul 3, 2024
Merged

Doc review fixes #153

merged 19 commits into from
Jul 3, 2024

Conversation

zuiderkwast
Copy link
Contributor

Fixes #120, fixes #121, fixes #122, fixes #124, fixes #125, fixes #126, fixes #127, fixes #128, fixes #130, fixes #131, fixes #132, fixes #133, fixes #134, fixes #135, fixes #136, fixes #137, fixes #138, fixes #139, fixes #140, fixes #141.

…alkey-io#141

* Remove junk line numbers in code examples and incorrect output in the valkey-cli prompt in examples in in cluster-tutorial.
* Remove reference to Redis OSS 3 and revert an occurrence of "adapterd to Redis coding style", since that's what this old code was.

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
valkey-io#132

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
…ors, valkey-io#127

Refactor the sections about various kinds of nulls.

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>


Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
…hlighing, valkey-io#121

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested ever effected page, but looks reasonable.

@zuiderkwast
Copy link
Contributor Author

Great, I'll merge this then. We can test further before deploying the website, if you want.

@zuiderkwast zuiderkwast merged commit 1cba52c into valkey-io:main Jul 3, 2024
2 checks passed
@zuiderkwast zuiderkwast deleted the doc-review-fixes branch July 3, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment