Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/topics/pipelining.md misnames a client and operating system #125

Closed
stockholmux opened this issue May 30, 2024 · 0 comments · Fixed by #153
Closed

/topics/pipelining.md misnames a client and operating system #125

stockholmux opened this issue May 30, 2024 · 0 comments · Fixed by #153

Comments

@stockholmux
Copy link
Member

In pre-publishing review (#91) I noticed the following issues on /topics/pipelining.md:

In the following benchmark we'll use the Valkey Ruby client, supporting pipelining, to test the speed improvement due to pipelining:

This refers to the Redis Ruby client, not a specific Valkey ruby client, which is confusing.

Running the above simple script yields the following figures on my Mac OS X system, running over the loopback interface

We should switch Mac OS X to MacOS (and perhaps modernize the results, I think they are quite old).
@stockholmux stockholmux mentioned this issue May 30, 2024
Open
70 tasks
zuiderkwast added a commit to zuiderkwast/valkey-doc that referenced this issue Jul 3, 2024
@zuiderkwast
pipelining.md, valkey-io#125
5847fdb 
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast zuiderkwast mentioned this issue Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doc review fixes zuiderkwast/valkey-doc
1 participant
@stockholmux