Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/topics/pubsub.md has very old, broken example. #128

Closed
stockholmux opened this issue May 30, 2024 · 1 comment · Fixed by #153
Closed

/topics/pubsub.md has very old, broken example. #128

stockholmux opened this issue May 30, 2024 · 1 comment · Fixed by #153

Comments

@stockholmux
Copy link
Member

In pre-publishing review (#91), I noticed that there is a linked example that probably does not work.

Programming example
Pieter Noordhuis provided a great example using EventMachine and Valkey to create a multi user high performance web chat.

On the linked gist it says:

# Update 7 Oct 2010:
# - This example does *not* appear to work with Chrome >=6.0. Apparently,
#   the WebSocket protocol implementation in the cramp gem does not work
#   well with Chrome's (newer) WebSocket implementation.

Note, the current version of Chrome is 125.x

@zuiderkwast
Copy link
Contributor

Deleting the "programming example".

zuiderkwast added a commit to zuiderkwast/valkey-doc that referenced this issue Jul 3, 2024
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants