Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SET: Be more explicit about replies when using GET in conjunction with XX/NX/IFEQ #206

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

gmbnomis
Copy link
Contributor

Based on the conversation/comment valkey-io/valkey#1415 (comment)

With PR valkey-io/valkey-io.github.io#183, the "RESP2 Reply" section looks like this for the web page:

image

…h XX/NX/IFEQ

Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is very clear.

@zuiderkwast zuiderkwast merged commit e839acd into valkey-io:main Jan 8, 2025
2 checks passed
@gmbnomis gmbnomis deleted the set_get_nx_xx_ifeq_reply branch January 8, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants