Add reply sections to command pages #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: valkey-io/valkey-doc#202 is necessary to make this work |
They are built from resp2_replies.json/resp3_replies.json from valkey-doc. If the RESP2/RESP3 replies are equal, only a single section is added. Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
gmbnomis
force-pushed
the
add_replies_to_web_pages
branch
from
972c5b5 to
a222e9f
Compare
stockholmux
reviewed
Dec 23, 2024
|
@gmbnomis Thanks for the work on this! If this is dependent on a PR in another repo, could you please make this a draft PR so it doesn't get accidentally merged. |
|
I put this PR into draft state (and will wait until valkey-io/valkey-doc#202 gets merged) |
|
are we still waiting on valkey-io/valkey-doc#206 @gmbnomis ? |
@stockholmux No, the necessary PR was valkey-io/valkey-doc#202, which is merged. valkey-io/valkey-doc#206 just depends on this PR to become visible on the website. |
madolson
approved these changes
Jan 7, 2025
|
I did some spot checking and the output looks OK to me, if someone finds some obscure issues we can fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are built from
resp2_replies.json/resp3_replies.jsonfrom valkey-doc. If the RESP2/RESP3 replies are equal, only a single section is added.Closes #185
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.