Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There are several patches in this PR:
bind
option is a special config,socket
andtls
are using the same one. However RDMA uses the similar style but different one. Use a bit abstract work to make it flexible for bothsocket
andRDMA
. Even for QUIC in the future.--rdma-bind
and--rdma-port
style instead of module parameters.make BUILD_RDMA=yes
. module style is still kept for now. Once module style is decided to drop, I volunteer to do it for TLS and RDMA together.Each patch has independent functionality, also been tested by CI and local commands, so request no-squash merge for this PR.