Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDMA builtin support #1209

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
Open

Commits on Oct 22, 2024

  1. Abstract set/rewrite config bind option

    Originally, special config 'bind' is used for socket and TLS, however
    multiple addresses handling is also workable for RDMA(QUIC in the
    future). Abstract bind option as helper functions to apply more
    connection types.
    
    rewriteConfigBindOption is a local function, declare it as 'static'
    function.
    
    Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
    pizhenwei committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d4448eb View commit details
    Browse the repository at this point in the history
  2. Introduce closeListener for connection type

    Socket family use close() syscall to close listener, however RDMA has
    another style. Use an abstract function handler instead of hard code
    syscall style.
    
    Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
    pizhenwei committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b6c0ea6 View commit details
    Browse the repository at this point in the history
  3. RDMA: Use valkey.conf style instead of module parameters

    Move 4 parameters from valkey-rdma.so to valkey-server, keep RDMA
    listener similar to TCP/TLS. Also prepare to build Valkey Over RDMA
    into builtin.
    
    Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
    pizhenwei committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    10626d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. RDMA: Support builtin

    Support RDMA builtin and module together. To build a builtin version:
     $ make BUILD_RDMA=yes
    
    Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
    pizhenwei committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    047c7ec View commit details
    Browse the repository at this point in the history