update valkey in serverLog messeges in server.c file #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwware
approved these changes
Apr 5, 2024
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Shivshankar-Reddy
force-pushed
the
update-server-serevrLog
branch
from
e55f9e7
to
d05083f
Compare
|
@zuiderkwast Can you review this PR? |
zuiderkwast
added
the
breaking-change
|
Partial implementation of #207. Log messages are breaking changes. Let's remember for release notes. |
zuiderkwast
approved these changes
Apr 11, 2024
| return 0; | ||
| #else | ||
| if (serverCommunicateSystemd("STATUS=Redis is loading...\n") <= 0) | ||
| if (serverCommunicateSystemd("STATUS=Valkey is loading...\n") <= 0) |
There was a problem hiding this comment.
This is a special message. Not a normal log entry. I'm marking it for special attention.
|
Oops, maybe we shouldn't merge this after the last discussions in #207. No problem. We can just update these again. |
zuiderkwast
pushed a commit
to zuiderkwast/placeholderkv
that referenced
this pull request
Apr 17, 2024
Updated keyword "Redis" to "Valkey" in log messeges in server.c file Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
Updated keyword "Redis" to "Valkey" in log messeges in server.c file Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated keyword "Redis" to "Valkey" in log messeges in server.c file