Occurrences of "Redis" in log entries #207
Comments
|
@0del do you want to do this one? |
|
Please assign it to me. Thanks. I will pick it up later, perhaps tomorrow morning. It's nighttime in my time zone now. |
|
We decided (in #254) to change all log entries containing "Redis" to use this style: also serverPanic is logging, so we use %s for this too: We shall define SERVER_TITLE to "Valkey" in server.h. (It's different to SERVER_NAME which is "valkey" with lowercase "v".) Skip the "=== REDIS BUG REPORT". We'll handle that in a separate PR for #274. For all the other log entres, I would prefer to have them all in one big PR. The risk for merge conflicts is less now that most other rebranding is already done. @0del are you still up for this? If not, I can do it. |
|
sure, i will still work on it |
|
@0del I'm adding the macro |
Log messages containing "Redis" in some files are changed. Add macro SERVER_TITLE defined to "Valkey" (uppercase V) is introduced and used in log messages, so at least it will be easy to patch this definition to get Redis or any other name in the logs instead of Valkey. Change "Redis" in some log messages to use %s and SERVER_TITLE. This is a partial implementation of #207 --------- Signed-off-by: 0del <bany.y0599@gmail.com>
Log messages containing "Redis" in some files are changed. Add macro SERVER_TITLE defined to "Valkey" (uppercase V) is introduced and used in log messages, so at least it will be easy to patch this definition to get Redis or any other name in the logs instead of Valkey. Change "Redis" in some log messages to use %s and SERVER_TITLE. This is a partial implementation of valkey-io#207 --------- Signed-off-by: 0del <bany.y0599@gmail.com>
|
Is this completed? @zuiderkwast |
|
I think there are some log messages left todo. |
Log messages containing "Redis" in some files are changed. Add macro SERVER_TITLE defined to "Valkey" (uppercase V) is introduced and used in log messages, so at least it will be easy to patch this definition to get Redis or any other name in the logs instead of Valkey. Change "Redis" in some log messages to use %s and SERVER_TITLE. This is a partial implementation of valkey-io#207 --------- Signed-off-by: 0del <bany.y0599@gmail.com>
…of-rewrite (#393) Renamed redis to valkey/server in aof.c serverlogs. The AOF rewrite child process title is set to "redis-aof-rewrite" if Valkey was started from a redis-server symlink, otherwise to "valkey-aof-rewrite". This is a breaking changes since logs are changed. Part of #207. --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
…of-rewrite (valkey-io#393) Renamed redis to valkey/server in aof.c serverlogs. The AOF rewrite child process title is set to "redis-aof-rewrite" if Valkey was started from a redis-server symlink, otherwise to "valkey-aof-rewrite". This is a breaking changes since logs are changed. Part of valkey-io#207. --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Part of #207 --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Part of valkey-io#207 --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
|
@zuiderkwast Do you recall if this was finalized? I thought we finished this, but Valkey 8 is when it should all be done. |
|
I'm not sure. We should probably |
$ git grep -i serverlog.*redis
src/module.c: serverLog(LL_NOTICE, "Legacy Redis Module %s found", path);
src/module.c: serverLog(LL_NOTICE, "Legacy Redis Module %s found", name);
src/rdb.c: serverLog(LL_NOTICE, "Loading RDB produced by Redis version %s", (char *)auxval->ptr);These are as expected. I can't see any multiline log entries with redis either. |
We decided (in #254) to change all log entries containing "Redis" to use this style:
also serverPanic is logging, so we use %s for this too:
We shall define SERVER_TITLE to "Valkey" in server.h. (It's different to SERVER_NAME which is "valkey" with lowercase "v".)
Skip the "=== REDIS BUG REPORT". We'll handle that in a separate PR for #274.
The text was updated successfully, but these errors were encountered: