Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace valkey in log and panic messages #550

Merged

Conversation

Shivshankar-Reddy
Copy link
Contributor

@Shivshankar-Reddy Shivshankar-Reddy commented May 24, 2024

Part of #207

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.22%. Comparing base (d72ba06) to head (b25e315).
Report is 23 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #550      +/-   ##
============================================
+ Coverage     70.19%   70.22%   +0.02%     
============================================
  Files           109      110       +1     
  Lines         59905    59991      +86     
============================================
+ Hits          42051    42128      +77     
- Misses        17854    17863       +9     
Files Coverage Δ
src/cluster_legacy.c 86.49% <ø> (+0.19%) ⬆️
src/rdb.c 75.55% <0.00%> (-0.48%) ⬇️

... and 32 files with indirect coverage changes

src/cluster_legacy.c Outdated Show resolved Hide resolved
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
src/rdb.c Outdated Show resolved Hide resolved
src/cluster_legacy.c Outdated Show resolved Hide resolved
src/rdb.c Outdated Show resolved Hide resolved
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
@zuiderkwast zuiderkwast merged commit 9319f7a into valkey-io:unstable Jun 4, 2024
17 checks passed
@zuiderkwast
Copy link
Contributor

Thanks!

naglera pushed a commit to naglera/placeholderkv that referenced this pull request Jun 10, 2024
Part of valkey-io#207

---------

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
@Shivshankar-Reddy Shivshankar-Reddy deleted the rename-logs-and-panic branch October 7, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants