Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typeahead with scroll #1168

Closed
arins opened this issue Oct 26, 2016 · 19 comments
Closed

typeahead with scroll #1168

arins opened this issue Oct 26, 2016 · 19 comments

Comments

@arins
Copy link

arins commented Oct 26, 2016

There is no possibility to have a long list with scroll with a typeahead component. You can add overflow-y:scroll to the ul element but that doesn't work when you use up/down arrow keys. I have made a fork and added two options two the typeahead.

typeaheadScrollable: boolean
typeaheadOptionsInScrollableView: number

if typeaheadScrollable is true the component container is scrollable and also reacts to key up/down keys.
You can also set number of items in the scrollable "view".

Is it possible to do a pull request on this when me and my colleague are done?

@gretchenheinel
Copy link

Once this is in, it would be immensely helpful for lazy-loading results once the user scrolls to the bottom of the list.

@arins
Copy link
Author

arins commented Nov 15, 2016

yes I can look into it after this has been merged and when I have time. I agree it's a pretty important feature if you have a lot of items and can not fetch them in one go.

@joebri
Copy link

joebri commented Jan 18, 2017

+1 for this feature. Is there an ETA?

@arins
Copy link
Author

arins commented Jan 19, 2017

Yes I need this feature as well that's why I implemented it but it seems valor software don't have time to merge this. They have not been responding on this for a while so we went ahead and created a clone of there pacakge https://www.npmjs.com/package/symbrio-ng2-bootstrap which has the scroll. I try to update our package when they do updates and with the scroll. You can use that until they merged this.

@valorkin valorkin added the WIP label Jan 19, 2017
@valorkin
Copy link
Member

@arins finaly I got here

@valorkin
Copy link
Member

@arins I am incredibly sorry, I was working with documentation >.<

@arins
Copy link
Author

arins commented Jan 20, 2017

Hi! I can make a new pull request. Because I saw there was a lot of changes in the master branch. It might be eaiser if I just make a new pull request.

@valorkin
Copy link
Member

@arins it would be very helpful
fork from development branch
I am merging into master only stable releases

@arins
Copy link
Author

arins commented Jan 20, 2017

@valorkin ok

@BenElliottBV
Copy link

Hi both!

Don't suppose there's any progress on this at all? We could really use this feature!

@M1strall
Copy link

M1strall commented Feb 8, 2017

Yea, we are also very interested in this feature

@arins
Copy link
Author

arins commented Feb 9, 2017

I have made a pull request so it's up to the repo owners to merge it. #1543

@Ankushi
Copy link

Ankushi commented Feb 22, 2017

Any further updates on this?

@M1strall
Copy link

Bump. Would be really great to support this.

@Argyos
Copy link

Argyos commented Mar 28, 2017

I need this with the intensity of thousand suns. Bump

@vikkivikrant
Copy link

vikkivikrant commented Jun 5, 2017

@arins @valorkin It will be really helpful if we can add this feature.

@puneetratan
Copy link

puneetratan commented Nov 10, 2018

try this

document.addEventListener("keydown", function (e) {
    document.getElementById(e.target.attributes['aria-activedescendant'].value).scrollIntoView(true)
});

@kamalSaiDd
Copy link

kamalSaiDd commented Apr 3, 2019

document.addEventListener("keydown", function (e) {
document.getElementById(e.target.attributes['aria-activedescendant'].value).scrollIntoView(true)
});

Wow it worked for me. You saved my day..

Just modified the following for angular 4+ (Make sure you add html tag (HTMLInputElement) as git hub is parsing out when i pasted the following code

document.addEventListener('keydown', (e) => {
document.getElementById((e.target).attributes['aria-activedescendant'].value).scrollIntoView(true);
});

@Chealer
Copy link

Chealer commented Jul 29, 2021

This feature is available (using the options mentioned by arins) in ngx-bootstrap 5.2.0 (and probably earlier).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests