-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typeahead): scroll feature for typeahead #1543
Conversation
Current coverage is 86.38% (diff: 88.39%)
@@ development #1543 diff @@
=============================================
Files 82 83 +1
Lines 2298 2387 +89
Methods 20 20
Messages 0 0
Branches 297 319 +22
=============================================
+ Hits 1952 2062 +110
+ Misses 246 217 -29
- Partials 100 108 +8
|
@valorkin I made a new pull request with your latest code. |
Awesome, thanks. I will still need to understand it better before merge |
@valorkin is there any update on when this might be merged? I am interested in this feature and trying to hold off on updating ng2-bootstrap until it is in. Thanks |
I am planning spent next week full-time for ng2-bootstrap |
@valorkin We are waiting for the update on fix for typeahead for not showing more than 20 records by default when no search was performed. Please let us know when this will be available |
Hello, are there any news on when this feature can be merged?.. |
This/next we are finishing modal component loader. And then going to work on Typeahead and datepicker fixes/rewrite |
Thanks @valorkin & @arins : Are you also adding feature where user can hold down/up arrow keys and it will keep moving to next/previous items. This will be very useful when you have too many items to look into. Adding below code will do it : Method to add it : Add below code into above method :
|
Need to solve conflicts |
@SergeyKuryatnick @valorkin @IlyaSurmay Any updates on this? |
@SergeyKuryatnick @valorkin @IlyaSurmay any updates on the scrollable feature? I am in a real need of this functionality. I tried to modify CSS to show the dropdown but I am experiencing some IE11 issues when the scroll button is clicked the dropdown closes. Much appreciate it. |
Huge thanks for PR! |
Implemented scroll for typeahead #1168