Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typeahead): scroll feature for typeahead #1543

Closed
wants to merge 3 commits into from
Closed

feat(typeahead): scroll feature for typeahead #1543

wants to merge 3 commits into from

Conversation

arins
Copy link

@arins arins commented Jan 23, 2017

Implemented scroll for typeahead #1168

@codecov-io
Copy link

Current coverage is 86.38% (diff: 88.39%)

Merging #1543 into development will increase coverage by 1.44%

@@           development      #1543   diff @@
=============================================
  Files               82         83     +1   
  Lines             2298       2387    +89   
  Methods             20         20          
  Messages             0          0          
  Branches           297        319    +22   
=============================================
+ Hits              1952       2062   +110   
+ Misses             246        217    -29   
- Partials           100        108     +8   

Powered by Codecov. Last update 62e2e81...e316e65

@arins
Copy link
Author

arins commented Jan 23, 2017

@valorkin I made a new pull request with your latest code.

@valorkin
Copy link
Member

Awesome, thanks. I will still need to understand it better before merge
DM me in slack I will share some details about typeahead plans

@valorkin valorkin changed the title Scroll feature for typeahead feat(typeahead): scroll feature for typeahead Jan 24, 2017
@arins arins mentioned this pull request Feb 9, 2017
@bwoodle
Copy link

bwoodle commented Mar 2, 2017

@valorkin is there any update on when this might be merged? I am interested in this feature and trying to hold off on updating ng2-bootstrap until it is in.

Thanks

@valorkin
Copy link
Member

valorkin commented Mar 3, 2017

I am planning spent next week full-time for ng2-bootstrap

@vsm-zz
Copy link

vsm-zz commented Apr 5, 2017

@valorkin We are waiting for the update on fix for typeahead for not showing more than 20 records by default when no search was performed. Please let us know when this will be available

@aleor
Copy link

aleor commented May 9, 2017

Hello, are there any news on when this feature can be merged?..

@vikkivikrant
Copy link

vikkivikrant commented Jun 15, 2017

@valorkin @arins Hi, any update on this, when this feature will be added?? It will be big win if we can add it soon. Thanks in advance.

@valorkin
Copy link
Member

This/next we are finishing modal component loader. And then going to work on Typeahead and datepicker fixes/rewrite

@vikkivikrant
Copy link

vikkivikrant commented Jun 19, 2017

Thanks @valorkin & @arins : Are you also adding feature where user can hold down/up arrow keys and it will keep moving to next/previous items. This will be very useful when you have too many items to look into.

Adding below code will do it :

Method to add it :
@HostListener('keydown', ['$event'])
public onKeydown(e: any):

Add below code into above method :

  // down
  while (e.keyCode === 40) {
    this._container.nextActiveMatch();
    return;
  }

  // up
  while (e.keyCode === 38) {
    this._container.prevActiveMatch();
    return;
  }

@vikkivikrant
Copy link

@valorkin @arins Any updates on this will be greatly appreciated.

@SergeyKuryatnick
Copy link
Contributor

Need to solve conflicts

@WhoStoleMyToast
Copy link

@SergeyKuryatnick @valorkin @IlyaSurmay Any updates on this?

@NickManojlovic
Copy link

@SergeyKuryatnick @valorkin @IlyaSurmay any updates on the scrollable feature? I am in a real need of this functionality. I tried to modify CSS to show the dropdown but I am experiencing some IE11 issues when the scroll button is clicked the dropdown closes. Much appreciate it.

@IlyaSurmay
Copy link
Contributor

Huge thanks for PR!
Due to the fact that lib structure has been changed a lot since this PR was created, we decided to take it as a draft and replace it with #2821.

@IlyaSurmay IlyaSurmay closed this Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.